Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react: useAddProfileInterests and useRemoveProfileInterests #915

Merged
merged 2 commits into from
Apr 29, 2024
Merged

react: useAddProfileInterests and useRemoveProfileInterests #915

merged 2 commits into from
Apr 29, 2024

Conversation

krzysu
Copy link
Contributor

@krzysu krzysu commented Apr 16, 2024

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 16, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 25205fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@lens-protocol/domain Minor
@lens-protocol/react Minor
@lens-protocol/react-native Minor
@lens-protocol/react-web Minor
@lens-protocol/api-bindings Patch
@lens-protocol/blockchain-bindings Patch
@lens-protocol/wagmi Major
@lens-protocol/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Apr 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lens-sdk-example-web-wagmi ✅ Ready (Inspect) Visit Preview Apr 29, 2024 0:33am

@height Height
Copy link

height bot commented Apr 16, 2024 •
edited
Loading

This pull request has been linked to 1 task:

💡Tip: Add "Close T-8629" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

@krzysu krzysu force-pushed the T-8629/-useaddinterests-and-useremoveinterests branch from b59aaa3 to 9bb0abd Compare April 16, 2024 14:59
@krzysu krzysu force-pushed the T-8629/-useaddinterests-and-useremoveinterests branch from 9bb0abd to a849b60 Compare April 17, 2024 09:09
@krzysu krzysu marked this pull request as ready for review April 17, 2024 09:09
@krzysu krzysu requested a review from cesarenaldi April 17, 2024 09:09
@krzysu krzysu force-pushed the T-8629/-useaddinterests-and-useremoveinterests branch from a849b60 to e192ad4 Compare April 17, 2024 09:10
@krzysu krzysu force-pushed the T-8629/-useaddinterests-and-useremoveinterests branch from e192ad4 to f242826 Compare April 17, 2024 09:26
@krzysu krzysu force-pushed the T-8629/-useaddinterests-and-useremoveinterests branch from f242826 to dfba4b7 Compare April 18, 2024 13:27
@krzysu krzysu force-pushed the T-8629/-useaddinterests-and-useremoveinterests branch from dfba4b7 to 6edfb92 Compare April 18, 2024 13:37
cesarenaldi
cesarenaldi reviewed Apr 23, 2024
View reviewed changes
packages/react/src/profile/useAddProfileInterests.ts Outdated
);

await add({
profileId: session.profile.id,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can one add interest to another profile other than the logged-in one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, but it is used in the presenter for optimistic update. also I didn't want to bring interests enum to the domain so I used only profileId in the domain request.
profileId is used only internally here, not exposed to the SDK user.

@krzysu krzysu force-pushed the T-8629/-useaddinterests-and-useremoveinterests branch from 6edfb92 to e9a5840 Compare April 24, 2024 09:21
@krzysu krzysu force-pushed the T-8629/-useaddinterests-and-useremoveinterests branch from e9a5840 to 25205fc Compare April 29, 2024 12:30
@krzysu krzysu merged commit 1e6b96c into develop Apr 29, 2024
6 checks passed
@krzysu krzysu deleted the T-8629/-useaddinterests-and-useremoveinterests branch April 29, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cesarenaldi cesarenaldi cesarenaldi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krzysu @cesarenaldi